[TASK] Remove redundant ORDER BY clause in default_sortby (#2189)

The ORDER BY clause is redundant and is removed by TYPO3 anyway. The link type defined both, sortby and default_sortby. This is invalid. In this case sortby overrules default_sortby and hence the latter can be removed.
georgringer · Sep 7, 2023 · d71e20e · d71e20e
1 parent 0d181e8
commit d71e20e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/Configuration/TCA/tx_news_domain_model_link.php b/Configuration/TCA/tx_news_domain_model_link.php
@@ -21,7 +21,6 @@
         'translationSource' => 'l10n_source',
         'versioningWS' => true,
         'origUid' => 't3_origuid',
-        'default_sortby' => 'ORDER BY sorting',
         'sortby' => 'sorting',
         'delete' => 'deleted',
         'enablecolumns' => [

diff --git a/Configuration/TCA/tx_news_domain_model_news.php b/Configuration/TCA/tx_news_domain_model_news.php
@@ -140,7 +140,7 @@
         'transOrigPointerField' => 'l10n_parent',
         'transOrigDiffSourceField' => 'l10n_diffsource',
         'translationSource' => 'l10n_source',
-        'default_sortby' => 'ORDER BY datetime DESC',
+        'default_sortby' => 'datetime DESC',
         'sortby' => ($configuration->getManualSorting() ? 'sorting' : ''),
         'delete' => 'deleted',
         'enablecolumns' => [

diff --git a/Configuration/TCA/tx_news_domain_model_tag.php b/Configuration/TCA/tx_news_domain_model_tag.php
@@ -19,7 +19,7 @@
         'transOrigPointerField' => 'l10n_parent',
         'transOrigDiffSourceField' => 'l10n_diffsource',
         'translationSource' => 'l10n_source',
-        'default_sortby' => 'ORDER BY title',
+        'default_sortby' => 'title',
         'delete' => 'deleted',
         'enablecolumns' => [
             'disabled' => 'hidden',