-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Allow developers to define their own view #1784
Open
AKaravas
wants to merge
8
commits into
georgringer:main
Choose a base branch
from
AKaravas:feature/define-view-event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
403e254
[FEATURE] Allow developers to define their own view
1d14af8
Fix code according to StyleCI
374b34a
apply changes according to comments
cf34678
apply changes according to comments
f733cb6
apply changes according to comments
a97e8ec
Remove comments where a type hinted function exists
d401ec4
Merge branch 'main' into feature/define-view-event
AKaravas 0114307
add comment on getView()
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
<?php | ||
declare(strict_types=1); | ||
|
||
AKaravas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
namespace GeorgRinger\News\Event; | ||
|
||
use GeorgRinger\News\Controller\NewsController; | ||
|
||
/** | ||
* This file is part of the "news" Extension for TYPO3 CMS. | ||
* | ||
* For the full copyright and license information, please read the | ||
* LICENSE.txt file that was distributed with this source code. | ||
*/ | ||
final class NewsInitializeActionEvent | ||
{ | ||
private $newsController; | ||
AKaravas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
private $defaultViewObjectName; | ||
|
||
private $action; | ||
|
||
/** | ||
* @param NewsController $newsController | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All not required, pleas remove |
||
* @param string $defaultViewObjectName | ||
* @param string $action | ||
*/ | ||
public function __construct(NewsController $newsController, string $defaultViewObjectName, string $action = '') | ||
{ | ||
$this->newsController = $newsController; | ||
$this->defaultViewObjectName = $defaultViewObjectName; | ||
$this->action = $action; | ||
} | ||
|
||
/** | ||
* @return NewsController | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not required, can be removed |
||
*/ | ||
public function getNewsController(): NewsController | ||
{ | ||
return $this->newsController; | ||
} | ||
|
||
/** | ||
* @param NewsController $newsController | ||
* @return $this | ||
*/ | ||
public function setNewsController(NewsController $newsController): self | ||
{ | ||
$this->newsController = $newsController; | ||
|
||
return $this; | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function getDefaultViewObjectName(): string | ||
{ | ||
return $this->defaultViewObjectName; | ||
} | ||
|
||
/** | ||
* @param string $defaultViewObjectName | ||
* @return NewsInitializeActionEvent | ||
*/ | ||
public function setDefaultViewObjectName(string $defaultViewObjectName): self | ||
{ | ||
$this->defaultViewObjectName = $defaultViewObjectName; | ||
|
||
return $this; | ||
} | ||
|
||
/** | ||
* @return string | ||
*/ | ||
public function getAction(): string | ||
{ | ||
return $this->action; | ||
} | ||
|
||
/** | ||
* @param string $action | ||
* @return NewsInitializeActionEvent | ||
*/ | ||
public function setAction(string $action): self | ||
{ | ||
$this->action = $action; | ||
|
||
return $this; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really unsure if that breaks in 10 because extbase can't get the type anymore of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe leave those changes, also imo not related to this feature, correct?