[BUGFIX] Replace deprecated addCacheTags calls #2531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSFE->addCacheTags() has been deprecated in TYPO3 13.3, see: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Deprecation-102422-TypoScriptFrontendController-addCacheTags.html This results in a TypeError in the frontend where the plugin is used. In this patch, the calls have been updated to use newly instantiated CacheTag objects instead of an array of strings. Resolves: georgringer#2530
| @@ -59,6 +60,7 @@ public function isContentRecordAlreadyProcessed(ContentObjectRenderer $cObj): bo | |||
| public static function addCacheTagsByNewsRecords($newsRecords): void | |||
| { | |||
| $cacheTags = []; | |||
| $cacheDataCollector = $GLOBALS['TYPO3_REQUEST']->getAttribute('frontend.cache.collector'); | |||
There was a problem hiding this comment.
Suggested change
| $cacheDataCollector = $GLOBALS['TYPO3_REQUEST']->getAttribute('frontend.cache.collector'); | |
| $cacheDataCollector = self::getRequest()->getAttribute('frontend.cache.collector'); |
| @@ -83,6 +82,7 @@ public static function addCacheTagsByNewsRecords($newsRecords): void | |||
| public static function addPageCacheTagsByDemandObject(NewsDemand $demand): void | |||
| { | |||
| $cacheTags = []; | |||
| $cacheDataCollector = $GLOBALS['TYPO3_REQUEST']->getAttribute('frontend.cache.collector'); | |||
There was a problem hiding this comment.
Suggested change
| $cacheDataCollector = $GLOBALS['TYPO3_REQUEST']->getAttribute('frontend.cache.collector'); | |
| $cacheDataCollector = self::getRequest()->getAttribute('frontend.cache.collector'); |
And add static method to get the request:
protected static function getRequest()
{
return $GLOBALS['TYPO3_REQUEST'];
}
|
thanks for the patch. as v12 is still supported, I need to handle that a bit different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSFE->addCacheTags() has been deprecated in TYPO3 13.3, see: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Deprecation-102422-TypoScriptFrontendController-addCacheTags.html This results in a TypeError in the frontend where the plugin is used. In this patch, the calls have been updated to use newly instantiated CacheTag objects instead of an array of strings.
Resolves: #2530