Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Meta Tag Refactoring #837

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

siwa-pparzer
Copy link
Contributor

Use PageTitleAPI for PageTitle creation
Use MetaTagManagerRegistry for MetaTag creation
Make Twitter site property not mandatory for Twitter card usage
Add Twitter title/description/image per default

Use PageTitleAPI for PageTitle creation
Use MetaTagManagerRegistry for MetaTag creation
Make Twitter site property not mandatory for Twitter card usage
Add Twitter title/description/image per default
Copy link
Owner

@georgringer georgringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to support typo3 8 still ;))

Skip titleTagIsSet Test for TYPO3 9
georgringer added a commit that referenced this pull request Oct 19, 2019
@simonschaufi
Copy link
Contributor

can this be rebased please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants