Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChaikinSmoothing for Geometry #1116

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

wtchen
Copy link
Contributor

@wtchen wtchen commented Nov 19, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Implements #930

Supports calling chaikin_smoothing on Geometry. If the variant has a ChaikinSmoothing implementation, call the method. Otherwise, just clone the geometry.

@frewsxcv
Copy link
Member

@wtchen Thank you! Can you add an entry to CHANGES.md? And address the linting errors in CI

@wtchen
Copy link
Contributor Author

wtchen commented Dec 6, 2023

Done, I fixed linting errors and added an entry to CHANGES.md. Can you review again @frewsxcv? 🙂

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@frewsxcv frewsxcv enabled auto-merge December 6, 2023 01:26
@frewsxcv frewsxcv added this pull request to the merge queue Dec 6, 2023
Merged via the queue into georust:main with commit 76ad2a3 Dec 6, 2023
15 checks passed
@wtchen wtchen deleted the geometry_chaikin_smoothing branch December 6, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants