docs: add diagram for event bus understanding #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groldan
requested changes
Oct 8, 2024
There was a problem hiding this comment.
thanks for this. The diagram looks good except the comments for 7a and 7b are specific to the reload/reset functionality, while the rest of the explanation and diagram is for the general case of remote/local events.
Maybe just mention the bridge will publish the remote event payload as a local event.
Then it's up to individual event listeners to perform any action required depending on the event type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic develop doc that might help new developers to better understand the event bus workflow