Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and docker-compose config #146

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

justpresident
Copy link
Contributor

How do you guys look at adding docker configuration? This would allow everyone on any platform (Windows, Mac, Linux) to build and run this Gephi Lite on their system without installing any tools and dependencies other than docker.

This allows building and running Gephi on any host and any operating
system without installing Node.js, npm and project dependecies.
@sim51
Copy link
Collaborator

sim51 commented Apr 2, 2024

Hi @justpresident

Gephi lite is just a static web application (build with react). So to deploy it, you just need a web server, that's all.

To build the application, you need npm.
So IMHO, you just replace the npm dependency by a docker one ... and for a web developer npm is a standard tool.

I like docker, and I use it in pretty much every project, because I have a complex stack, with a backend, a database ... but here it's too simple.

What is possible to do, is to build the application for each release .

@justpresident
Copy link
Contributor Author

I see that for web developers installing npm is not a big deal, they already have it. But for backenders like me, who want to try running a random app from github, running it in docker is the only way. I wouldn't even try running it directly on my servers. Not only because of npm requirement, but also for security, as I didn't read the code and have no idea how the project is set up.

but here it's too simple.

It is not about simplicity. Having a docker recipe is good for project adoption. More people would be willing to try it in a way that is secure and doesn't pollute the system with unnecessary dependencies.

- only compose volume, no copy so no dockerfile
- entrypoint to install and start
- as node user to preserve 1000:1000 user in node_modules
@paulgirard
Copy link
Collaborator

I ended up submitting a new commit that corrects the many issues with this PR.
@sim51 can you double check?

@sim51 sim51 merged commit 84ecac7 into gephi:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants