Merge pull request #197 from gerlero/plist

Revert "Add CFBundleIdentifier to Info.plist"
gerlero · Oct 4, 2023 · eef75da · eef75da
2 parents ee7d43d + 7d62444
commit eef75da
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/Contents/Info.plist b/Contents/Info.plist
@@ -6,8 +6,6 @@
 	<string>launch</string>
 	<key>CFBundleIconFile</key>
 	<string>icon.icns</string>
-	<key>CFBundleIdentifier</key>
-	<string>{{APP_IDENTIFIER}}</string>
 	<key>CFBundleVersion</key>
 	<string>{{APP_VERSION}}-{{DEPENDENCIES_KIND}}-{{ARCH}}</string>
 	<key>CFBundleShortVersionString</key>

diff --git a/Makefile b/Makefile
@@ -19,7 +19,6 @@ WMAKE_NJOBS =
 DEPENDENCIES_KIND = standalone
 DMG_FORMAT = UDRO
 APP_HOMEPAGE = https://github.com/gerlero/openfoam-app
-APP_IDENTIFIER = io.github.gerlero.openfoam-app
 APP_VERSION =
 TEST_DIR = build/test-v$(OPENFOAM_VERSION)
 
@@ -84,7 +83,6 @@ build/$(APP_NAME).app: $(APP_CONTENTS)
 build/$(APP_NAME).app/Contents/Info.plist: Contents/Info.plist | build/$(APP_NAME).app/Contents/MacOS/launch build/$(APP_NAME).app/Contents/Resources/icon.icns
 	mkdir -p build/$(APP_NAME).app/Contents
 	cp Contents/Info.plist build/$(APP_NAME).app/Contents/
-	sed -i '' "s|{{APP_IDENTIFIER}}|$(APP_IDENTIFIER)|g" build/$(APP_NAME).app/Contents/Info.plist
 	sed -i '' "s|{{APP_VERSION}}|$(APP_VERSION)|g" build/$(APP_NAME).app/Contents/Info.plist
 	sed -i '' "s|{{DEPENDENCIES_KIND}}|$(DEPENDENCIES_KIND)|g" build/$(APP_NAME).app/Contents/Info.plist
 	sed -i '' "s|{{ARCH}}|$(shell uname -m)|g" build/$(APP_NAME).app/Contents/Info.plist