Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add CFBundleIdentifier to Info.plist" #197

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Revert "Add CFBundleIdentifier to Info.plist" #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Contents/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
<string>launch</string>
<key>CFBundleIconFile</key>
<string>icon.icns</string>
<key>CFBundleIdentifier</key>
<string>{{APP_IDENTIFIER}}</string>
<key>CFBundleVersion</key>
<string>{{APP_VERSION}}-{{DEPENDENCIES_KIND}}-{{ARCH}}</string>
<key>CFBundleShortVersionString</key>
Expand Down
2 changes: 0 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ WMAKE_NJOBS =
DEPENDENCIES_KIND = standalone
DMG_FORMAT = UDRO
APP_HOMEPAGE = https://github.com/gerlero/openfoam-app
APP_IDENTIFIER = io.github.gerlero.openfoam-app
APP_VERSION =
TEST_DIR = build/test-v$(OPENFOAM_VERSION)

Expand Down Expand Up @@ -84,7 +83,6 @@ build/$(APP_NAME).app: $(APP_CONTENTS)
build/$(APP_NAME).app/Contents/Info.plist: Contents/Info.plist | build/$(APP_NAME).app/Contents/MacOS/launch build/$(APP_NAME).app/Contents/Resources/icon.icns
mkdir -p build/$(APP_NAME).app/Contents
cp Contents/Info.plist build/$(APP_NAME).app/Contents/
sed -i '' "s|{{APP_IDENTIFIER}}|$(APP_IDENTIFIER)|g" build/$(APP_NAME).app/Contents/Info.plist
sed -i '' "s|{{APP_VERSION}}|$(APP_VERSION)|g" build/$(APP_NAME).app/Contents/Info.plist
sed -i '' "s|{{DEPENDENCIES_KIND}}|$(DEPENDENCIES_KIND)|g" build/$(APP_NAME).app/Contents/Info.plist
sed -i '' "s|{{ARCH}}|$(shell uname -m)|g" build/$(APP_NAME).app/Contents/Info.plist
Expand Down