Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces slice_deque with slice_ring_buffer (maintained fork) #38

Closed

Conversation

LiquidityC
Copy link

Fixes: #29

@germangb
Copy link
Owner

germangb commented Dec 8, 2021

Thanks for the PR. I'm a bit busy lately but soon I will have free time to catch up

@LiquidityC
Copy link
Author

No worries. In your own time

@ArthurKValladares
Copy link

ArthurKValladares commented Jan 14, 2022

Thanks so much for the PR. This touches some code that causes apps using this crate to fail App Store Certification, which we can fix by exposing a slice_ring_buffer crate feature like I did here:
https://github.com/LiquidityC/minimp3-rs/pull/1

I now realize that I probably should have opened this as its own PR, instead of forking from this one, which I can do if that's preferred.

Expose `unix_sysv` feature in `slice-ring-buffer`
@ImUrX
Copy link

ImUrX commented Nov 25, 2022

@germangb any news?

@est31
Copy link

est31 commented Jul 25, 2023

@germangb I've received RustAudio/rodio#504 and will merge it, but would love if this PR could be merged (or maintenance be given to other people) so that I can switch back to the proper minimp3.

@LiquidityC LiquidityC closed this by deleting the head repository Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SliceDeque flagged as unsafe in 'cargo audit'
5 participants