Support re-use of a single preallocated pcm buffer #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I was not a fan of allocating on every single frame either. I'll take a look 😃 |
uklotzde
reviewed
May 29, 2021
|
|
||
| Ok(Frame { | ||
| data: pcm.data, | ||
| sample_rate: frame.sample_rate, |
|
|
||
| Ok(Frame { | ||
| data: pcm.data, | ||
| sample_rate: frame.sample_rate, |
| /// A MP3 frame, referencing the decoded audio of that frame. | ||
| #[derive(Debug, Clone)] | ||
| pub struct FrameInfo { | ||
| /// This frame's sample rate in hertz. |
| pub channels: usize, | ||
| /// MPEG layer used by this file. | ||
| pub layer: usize, | ||
| /// Current bitrate as of this frame, in kb/s. |
There was a problem hiding this comment.
kbit/s? To avoid confusing it with kB or KB.
| /// assert_eq!(&pcm[..], &[]); | ||
| /// ``` | ||
| #[derive(Debug)] | ||
| pub struct Pcm { |
There was a problem hiding this comment.
PcmFrame or FrameSamples, consistent with the naming of FrameInfo? Because it is supposed to store the samples decoded from a single MP3 frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following structures and methods:
Pcmwhich is a user provided collection allocated to the size ofMAX_SAMPLES_PER_FRAMEthat dereferences to its stored pcm data&[i16].FrameInfowhich just contains the frame header parts of the frame, excluding the data.next_frame_with_pcmwhich allows for decoding the frame data in-place a previously allocatedPcmstructure.next_frame_with_pcm_futureasync version ofnext_frame_into.This allows a caller to preallocate and re-use a single pcm buffer so it doesn't have to be allocated on each call to
next_frameto avoid its allocation overhead.The naming is preliminary, suggestions are welcome!