Fix dragging header width #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 10, 2015 12:41
Attempting to change the width of a column causes the header view to grow and shrink erratically. After investigating it appears the event.pageX value used the first time SC.TableHeaderView:mouseDragged() is called is undefined causing the newWidth calculation to generate erratic values. Saved the X position in the mouseDown() function then check the event.pageX for undefined in mouseDragged(). If undefined use the saved X position.
Add option to control acting on a column select. Turned off by default so reordering a column or just changing the width does not cause a sort action. Setting to true reverts to selecting a column on each click.
Temporary fix to inconsistent reloading behavior after a column reorder or width change. This fix turns off pooling of rows, which is fine for the default case where the row views are simple divs around plain text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to change the width of a column causes the header view to
grow and shrink erratically. After investigating it appears the
event.pageX value used the first time SC.TableHeaderView:mouseDragged()
is called is undefined causing the newWidth calculation to generate
erratic values.
Saved the X position in the mouseDown() function then check the
event.pageX for undefined in mouseDragged(). If undefined use the saved
X position.