Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds require URI to faraday connection #116

Closed
wants to merge 1 commit into from
Closed

Conversation

erikjenks
Copy link
Member

JIRA

Changes

  • Adds require 'uri' to the Faraday::Connection module after getting /home/docker/.gem/ruby/2.7.0/gems/scorm_engine-0.9.0/lib/scorm_engine/faraday/connection.rb:9:in base_uri': undefined method URI' for #<ScormEngine::Client:0x00007f6d40d049b8> (NoMethodError)

Checklist

  • Feature Flag Required
  • Bug

Test plan

  • Walk-through
  • Peer review
  • Inspection
    • Detailed steps and prerequisites for validating the change:

Risk Analysis - the risk of change is evaluated

  • Low - Majority of the changes are low risk which doesn’t require extra testing, only code review by 1 reviewer
    • 1 reviewer
  • Medium - Some portion of changes are medium risk which need peer testing and review by 2 reviewers
    • 2 reviewers
    • peer testing
  • High - A very few breaking changes are high risk and need very throughout testing and review and also coordinated release process.
    • 2 reviewers
    • peer testing
    • coordinated release

@erikjenks erikjenks closed this Oct 27, 2024
@erikjenks erikjenks deleted the adding-require-uri branch October 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant