Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try vault running via testcontainers #197

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

psi
Copy link
Member

@psi psi commented Feb 12, 2024

No description provided.

@psi psi requested a review from a team as a code owner February 12, 2024 21:19
@psi psi changed the base branch from master to dep-update-20240119 February 12, 2024 21:22
This replaces our previous Vault test implementation, which relied on
half a dozen or so Vault packages and instead uses the [testcontainers
Vault module](https://golang.testcontainers.org/modules/vault/). Now,
the only requirement is a container runtime.
Copy link
Member

@jppakalapati jppakalapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass!

@shakahl shakahl merged commit 1024195 into dep-update-20240119 Feb 13, 2024
1 check passed
@shakahl shakahl deleted the vault-testcontainers branch February 13, 2024 17:33
shakahl added a commit that referenced this pull request Feb 15, 2024
* Updated all dependencies 2014-01-19

* Updated all dependency

* Upgraded the packagest to the highest available version

* More on dependency resolution

* Try vault running via testcontainers (#197)

This replaces our previous Vault test implementation, which relied on
half a dozen or so Vault packages and instead uses the [testcontainers
Vault module](https://golang.testcontainers.org/modules/vault/). Now,
the only requirement is a container runtime.

---------

Co-authored-by: JD Harrington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants