Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse usernames with underscore #232

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jppakalapati
Copy link
Member

JIRA

Changes

  • My laptop's username is jp_pakalapati. Whenever I run truss shell it didn't convert my username properly and causes issues when assigning my name to the temporary shell pod. Fixing it with a string replacer.

Checklist

    • Feature Flag Required
    • Bug

Test plan

    • Walk-through
    • Peer review
    • Inspection
  • Detailed steps and prerequisites for validating the change:

Risk Analysis - the risk of change is evaluated

    • Low - Majority of the changes are low risk which doesn’t require extra testing, only code review by 1 reviewer
        • 1 reviewer
    • Medium - Some portions of changes are medium risk which needs peer testing and review by 2 reviewers
        • 2 reviewers
        • peer testing
    • High - A very few breaking changes are high risk and need very throughout testing and review and also a coordinated release process.
        • 2 reviewers
        • peer testing
        • coordinated release

@jppakalapati jppakalapati self-assigned this Jul 24, 2024
@jppakalapati jppakalapati requested a review from a team as a code owner July 24, 2024 21:54
Copy link
Member

@gombb gombb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jppakalapati jppakalapati merged commit 15c289c into master Jul 24, 2024
1 check passed
@jppakalapati jppakalapati deleted the fix-underscore-usernames branch July 24, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants