fixes problems with quoting: true

[ernestoongaro]

Quite similar to #52 (which was fixed) it looks like there is a few more places where tables need to get aliased.

As part of this would like to also see about adding a test configuration where we try this setting on every PR, or at least add it to a linting rule

[ian-whitestone]

@NiallRees can you have a look at this?

[ian-whitestone]

thanks for opening the PR @ernestoongaro and apologies for the delays here! will hopefuly get this merged in tomorrow. thanks for your patience!

[ernestoongaro]

No problem @ian-whitestone ! I'm having a customer test this on a huge codebase with quoting on schema/identifier/database so I'm glad it's not merged yet as I want to make sure we catch all problems.

Would love to add a test configuration that tests quoting on & off. It's unfortunately a thing people do :(

[NiallRees]

Approving but realise you still might make some more changes, so let me know when you're finished!

[ernestoongaro]

Approving but realise you still might make some more changes, so let me know when you're finished!

thanks @NiallRees that's amazing. Finished doing a "production" run and everything is working now with the last 2 commits. Any thoughts on adding an automated test with these settings? Though it's rare, people seem to want to quote identifiers from time to time

quoting:
  database: true
  schema: true
  identifier: true

[ernestoongaro]

So had a chat to @NiallRees about longterm support for aliases:
One option was to create a custom version of ref like (1) below

Another option was to use import CTEs which have implicit casting

but the option we went for today was to leave it alone and just merge this.

(1)

{% macro ref(model_name, alias=True) %}

  {% set original_ref = builtins.ref(model_name) %}

  {{ original_ref }}{{ if alias }} as model_name{{ endif }}

{% endmacro %}