Undo service_type transformation in stg_rate_sheet_daily and fix service_type filters in cost_per_query and hourly_spend
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stumelius
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
stumelius
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
eunkenl
reviewed
Apr 4, 2024
models/cost_per_query.sql
Outdated
| @@ -188,10 +188,10 @@ inner join credits_billed_daily | |||
| on date(all_queries.start_time) = credits_billed_daily.date | |||
| left join {{ ref('daily_rates') }} as daily_rates | |||
| on date(all_queries.start_time) = daily_rates.date | |||
| and daily_rates.service_type = 'COMPUTE' | |||
| and daily_rates.service_type = 'WAREHOUSE_METERING' | |||
There was a problem hiding this comment.
this should probably be CLOUD_SERVICES based on the data in daily rates
models/cost_per_query.sql
Outdated
| and daily_rates.usage_type = 'cloud services' | ||
| inner join {{ ref('daily_rates') }} as current_rates | ||
| on current_rates.is_latest_rate | ||
| and current_rates.service_type = 'COMPUTE' | ||
| and current_rates.service_type = 'WAREHOUSE_METERING' |
NiallRees
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
approved these changes
May 6, 2024
NiallRees
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
approved these changes
May 6, 2024
|
Thanks for your contribution @stumelius! This is included in release 5.1.0 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR undoes the
CASEstatement that forced the daily rate sheetservice_typeto eitherSTORAGEorCOMPUTEinstg_rate_sheet_dailyand fixes allservice_typefilters in the package accordingly.I cross referenced the hard-coded
service_typevalues with snowflake.organization_usage.rate_sheet_daily, snowflake.account_usage.metering_history and snowflake.account_usage.metering_daily_history. I also did manual validation checks to ensure that the compute spend values are being populated in thedaily_spendmodel.