Fix incremental filtering #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
commented
May 24, 2024
| @@ -72,7 +75,8 @@ from {{ source('snowflake_account_usage', 'query_history') }} | |||
|
|
|||
| {% if is_incremental() %} | |||
| -- must use end time in case query hasn't completed | |||
| where end_time > (select max(end_time) from {{ this }}) | |||
| -- add lookback window of 2 days to account for late arriving queries | |||
| where end_time > (select dateadd(day, -2, coalesce(max(end_time), '1970-01-01') ) from {{ this }}) | |||
There was a problem hiding this comment.
serverless tasks take some time to arrive in the query history. I'm still working out the exact delay, but starting here.
NiallRees
approved these changes
May 24, 2024
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
ian-whitestone
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an annoying bug where a table is created for the first time with no records, and then subsequent incremental filters like:
where end_time > (select max(end_time) from {{ this }})evaluate to null (because the table is empty), which results in no new records being inserted