👷 enable the --ir-minimum flag for forge coverage
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the FCL repository, @nlordell pointed out the mulmuladd function had a bug revealed by the edge cases committed by @rdubois-crypto. This PR fixes that bug like @nlordell did and add the relevant edge cases. Link of the initial PR: rdubois-crypto/FreshCryptoLib#5 Co-authored-by: Nicholas Rodrigues Lordello <[email protected]> Co-authored-by: rdubois-crypto <[email protected]>
By moving the assignment of variable `T3` further down the function, our stack management is now more efficient. This gives us greater flexibility.
The coverage commands do not run the optimizer, meaning it is more sensible to the stack depth error. We have reached a point where our stack management can't do without the optimizer, that's why we have to enable this flag for the coverage command.
LCOV of commit
|
qd-qd
changed the title
--ir-minimum flag for forge coverage
It seems the new configuration of the tests return now a different code coverage. This is probably due to the fact that the tests are now run with the `--ir-minimum` flag. In waiting for an investigation, I remove the treshold for the code coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage commands do not run the optimizer, meaning it is more
sensible to the stack depth error. We have reached a point where our stack
management can't do without the optimizer, that's why we have to enable
this flag for the coverage command.