Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed rollover if the wallet hasn't synced yet #2630

Open
holzeis opened this issue Jun 17, 2024 · 0 comments
Open

Failed rollover if the wallet hasn't synced yet #2630

holzeis opened this issue Jun 17, 2024 · 0 comments
Assignees
@holzeis
Labels
bug Something isn't working

Comments

@holzeis
Copy link
Contributor

holzeis commented Jun 17, 2024 •
edited
Loading

If a position gets opened very close to the rollover window, it could happen that the app still hasn't synced yet, thus leaving the underlying contract in signed instead of confirmed.

When opening a position we check if the underlying contract is confirmed we should do the same when processing a rollover. Note, I am referring here to the app side, as the coordinator already implements this check.

image
@holzeis holzeis added the bug Something isn't working label Jun 17, 2024
@holzeis holzeis mentioned this issue Jun 17, 2024
Open
@holzeis holzeis self-assigned this Jun 17, 2024
holzeis added a commit that referenced this issue Jun 17, 2024
@holzeis
fix: Only accept a rollover offer if the contract has been confirmed.
9635806 
Syncs the wallet eagerly if the channel is not yet confirmed.

If the contract is not confirmed, the rollover offer gets rejected. This fixes an issue where the app otherwise risk ending up in an intermediate state as it can't accept the `RenewConfirm` message.

see #2630
@holzeis holzeis mentioned this issue Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holzeis holzeis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Only accept a rollover offer if the contract has been confirmed. get10101/10101
1 participant
@holzeis