fix: Only accept a rollover offer if the contract has been confirmed. #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analogue to what we do when opening a position. We check if the contract is confirmed. If not, we sync eagerly - thus increasing the chances that the rollover proposal will succeed. This covers a small edge case where the user opened a position right before the rollover window and the coordinator hasn't synced yet.
Syncs the wallet eagerly if the channel is not yet confirmed. If the contract is not confirmed, the rollover offer gets rejected. This fixes an issue where the app otherwise risk ending up in an intermediate state as it can't accept the `RenewConfirm` message. see #2630
|
@luckysori Any idea why 9635806 doesn't fix the issue? Even though I pass the check if confirmed contract check when processing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs the wallet eagerly if the channel is not yet confirmed.
If the contract is not confirmed, the rollover offer gets rejected. This fixes an issue where the app otherwise risk ending up in an intermediate state as it can't accept the
RenewConfirmmessage.fixes #2630