Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only accept a rollover offer if the contract has been confirmed. #2633

Closed
wants to merge 3 commits into from
Closed

fix: Only accept a rollover offer if the contract has been confirmed. #2633

wants to merge 3 commits into from

Commits on Jun 17, 2024

  1. refactor: Remove unnecessary pool argument

    @holzeis
    holzeis committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    d42783f View commit details
    Browse the repository at this point in the history

  2. feat: Sync channel eagerly when proposing a rollover 

    Analogue to what we do when opening a position. We check if the contract is confirmed. If not, we sync eagerly - thus increasing the chances that the rollover proposal will succeed.

This covers a small edge case where the user opened a position right before the rollover window and the coordinator hasn't synced yet.
    @holzeis
    holzeis committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a78ea65 View commit details
    Browse the repository at this point in the history

  3. fix: Only accept a rollover offer if the contract has been confirmed. 

    Syncs the wallet eagerly if the channel is not yet confirmed.

If the contract is not confirmed, the rollover offer gets rejected. This fixes an issue where the app otherwise risk ending up in an intermediate state as it can't accept the `RenewConfirm` message.

see #2630
    @holzeis
    holzeis committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9635806 View commit details
    Browse the repository at this point in the history