feat: add phone lock (pin, biometrics, etc) #120
Conversation
im-adithya
requested review from
rolznz and
reneaaron
and removed request for
rolznz
There was a problem hiding this comment.
Great PR! Just tested it and it worked like a charm 👍
If you haven't set up biometrics on your phone you won't see this setting now. I wondered if that can lead to some confusion for users (who might see a screenshot in the docs, etc). Would it be better to always display the setting, but disable / explain you first have to set it up the /security page?
|
Yeah I had the same question, maybe we keep the setting and gray it out if biometrics aren't added? (with some text below suggesting to add biometrics to enable?) Also we somehow have to explain this feature as well, maybe right after the onboarding & wallet setup we show a popup saying "Add biometrics" / Setup Later? |
That probably breaks the rhythm of the settings page here, that's why i suggested to always display the setting but explain you have to enable it on the detail page.
I don't think we need to include it an the onboarding at this point. Let's keep it simple, users can enable it after they familiarized themselves with the app. |
|
does this only work with biometrics or also with some "normal" unlock screen? I don't use Face ID and fingerprints just to make the wrench attack a little harder :D |
|
Yes it works with any pattern/pin/password you set for unlock screen not just face id/fingerprint |
|
Tried to improve the copy a bit and replaced the custom alert with a card. |
reneaaron
changed the title
Fixes #35
Description
Adds basic auth using
expo-local-authentication, also adds this lock if the inactivity time is more than 5s (when kept in background) (I think we can increase this a bit)And do we wish to add a screen to block the display when it's in recent apps, let me know if I should add that as well
Screenshots