Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard submit type #89

Merged
merged 3 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@
"bundleIdentifier": "com.getalby.mobile",
"config": {
"usesNonExemptEncryption": false
},
"buildNumber":
}
},
"android": {
"package": "com.getalby.mobile",
Expand Down
3 changes: 2 additions & 1 deletion components/DualCurrencyInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,12 @@ export function DualCurrencyInput({
placeholder="0"
keyboardType="number-pad"
value={inputMode === "sats" ? amount : fiatAmount}
cursorColor={CURSOR_COLOR}
selectionColor={CURSOR_COLOR}
onChangeText={onChangeText}
aria-labelledbyledBy="amount"
style={styles.amountInput}
autoFocus={autoFocus}
returnKeyType="done"
// aria-errormessage="inputError"
/>
<Pressable onPress={toggleInputMode}>
Expand Down
2 changes: 1 addition & 1 deletion components/ui/input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const Input = React.forwardRef<
props.editable === false && 'opacity-50 web:cursor-not-allowed',
className
)}
cursorColor={CURSOR_COLOR}
selectionColor={CURSOR_COLOR}
placeholderClassName={cn('text-muted-foreground', placeholderClassName)}
{...props}
/>
Expand Down
1 change: 1 addition & 0 deletions pages/receive/Receive.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ export function Receive() {
placeholder="No description"
value={comment}
onChangeText={setComment}
returnKeyType="done"
/>
</View>
</View>
Expand Down
1 change: 1 addition & 0 deletions pages/send/LNURLPay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export function LNURLPay() {
placeholder="Enter an optional comment"
value={comment}
onChangeText={setComment}
returnKeyType="done"
/>
</View>
<View>
Expand Down
1 change: 1 addition & 0 deletions pages/send/Send.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export function Send() {
onChangeText={setKeyboardText}
inputMode="email"
autoFocus
returnKeyType="done"
// aria-errormessage="inputError"
/>
</View>
Expand Down
1 change: 1 addition & 0 deletions pages/settings/FiatCurrency.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export function FiatCurrency() {
placeholder="USD"
value={fiatCurrency}
onChangeText={setFiatCurrency}
returnKeyType="done"
// aria-errormessage="inputError"
/>
</View>
Expand Down
2 changes: 2 additions & 0 deletions pages/settings/address-book/NewAddressBookEntry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export function NewAddressBookEntry() {
value={name}
onChangeText={setName}
aria-labelledbyledBy="name"
returnKeyType="done"
// aria-errormessage="inputError"
/>
<Label
Expand All @@ -49,6 +50,7 @@ export function NewAddressBookEntry() {
placeholder="[email protected]"
onChangeText={setLightningAddress}
aria-labelledbyledBy="lightningAddress"
returnKeyType="done"
// aria-errormessage="inputError"
/>
</View>
Expand Down
1 change: 1 addition & 0 deletions pages/settings/wallets/LightningAddress.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export function LightningAddress() {
placeholder="[email protected]"
value={lightningAddress}
onChangeText={setLightningAddress}
returnKeyType="done"
// aria-errormessage="inputError"
/>
</View>
Expand Down
1 change: 1 addition & 0 deletions pages/settings/wallets/NewWallet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export function NewWallet() {
onChangeText={setName}
aria-labelledbyledBy="name"
placeholder="Enter a name for your wallet"
returnKeyType="done"
// aria-errormessage="inputError"
/>
</View>
Expand Down
1 change: 1 addition & 0 deletions pages/settings/wallets/RenameWallet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export function RenameWallet() {
placeholder={DEFAULT_WALLET_NAME}
value={walletName}
onChangeText={setWalletName}
returnKeyType="done"
// aria-errormessage="inputError"
/>
</View>
Expand Down
Loading