Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exponential backoff to subscriptions #106

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya commented Aug 22, 2024

  • Adds exponential backoff starting from 0s, 2s, 4s ... till 15m and keeps trying every 15m post that.
  • Fixes subscriptions not being stopped internally (which can bloat the svc.susbcriptions) when ctx is cancelled during relay connection.
  • Also fixes the issue where relays which had connection errors leading to panic on relay.Close() (it was an issue in go-nostr where relay.Connection is not checked before closing)

@im-adithya im-adithya requested a review from bumi August 22, 2024 14:35
@im-adithya im-adithya merged commit 12d12b1 into main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant