Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webhook support #15

Merged
merged 17 commits into from
Feb 27, 2024
Merged

feat: add webhook support #15

merged 17 commits into from
Feb 27, 2024

Conversation

im-adithya
Copy link
Member

Fixes #8

Description

The /nip47 endpoint now accepts a webhookUrl in the POST request. When passed, it immediately returns with "webhook received" like this:

Screenshot 2024-02-13 at 2 34 26 PM

And would make a POST request passing the responseEvent to the WebhookUrl specified in the request like this:

Screenshot 2024-02-13 at 2 35 41 PM

@im-adithya im-adithya requested a review from bumi February 13, 2024 09:08
@bumi
Copy link
Contributor

bumi commented Feb 13, 2024

Think about what we do if the app restarts before the reply came in.

@im-adithya im-adithya merged commit 257b89a into main Feb 27, 2024
1 check passed
@im-adithya im-adithya deleted the task-webhook branch May 28, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook support
2 participants