Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support limit and offset in list transactions #13

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

im-adithya
Copy link
Member

  • Adds support for limit and offset parameters
  • Also adds the transaction hint in the Onboardsing Checklist
Screenshot 2024-07-04 at 6 03 00 PM

@im-adithya im-adithya requested review from rolznz and reneaaron and removed request for rolznz July 5, 2024 08:45
@im-adithya
Copy link
Member Author

See getAlby/nostr-wallet-connect-next#572 for more info

@rolznz
Copy link
Contributor

rolznz commented Jul 5, 2024

@im-adithya should we wait for the dynamic budgets / internal transactions PR to be merged then? because if we add this code but it is not used on the frontend, it seems wrong to me

@im-adithya
Copy link
Member Author

Hmmm, the reason why I added this is because we need only one transaction to check the transaction item in the list, so there I'm using the limit, if you think this causes many conflicts in dynamic budgets, I can close, upto you 👍

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz
Copy link
Contributor

rolznz commented Jul 8, 2024

@im-adithya ah, I see. Thanks!

@rolznz
Copy link
Contributor

rolznz commented Jul 8, 2024

@im-adithya we could do even better by also supporting the type param (See https://github.com/nostr-protocol/nips/blob/master/47.md#list_transactions) and then we can have checklist items for both sending and receiving by getting the first incoming and outgoing transactions

@rolznz rolznz merged commit e401a1e into master Jul 8, 2024
7 of 8 checks passed
@rolznz rolznz deleted the task-transaction-params branch July 8, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants