-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add close channel dialog #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just from a quick glance at the screenshots:
-
"Proceed only if you still want to continue" - Either remove or rephrase, but this feels wrong.
-
If you present the user with 2 options (where the user can only pick one) rather use selects / radios than checkboxes, checkboxes always suggest you can pick multiple ones)
Yeah felt weird to me as well, will remove it entirely, maybe we can change the "Continue" in the button text to something else?
I was a bit hesitant to use Radio as that would add another component, so I used existing one. I didn't use Select/Boxes like budget options as I wanted to add description so it's more understandable for the user. So |
Sure, maybe "Confirm"?
Yeah, I'd go for that one. 👍 |
Done! |
@reneaaron @im-adithya I'm not sure about the UI. Ideally users do normal closures, so I don't think they should have to pick between the two like this. The force closure option should be a last resort |
We agreed on making the copy understandable and dealing with the Normal / Force Close UI later. Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Description
window.alert
,prompt
andconfirm
don't work in wails. We can use Dialog but it has some limitations in MacOS. Also the flow for closing a channel involves the user to type "force close" which is not ideal. This PR replaces those with AlertDialog from shadcn for Wails support as well as design consistency