Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve install scripts for linux #395

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Conversation

bumi
Copy link
Contributor

@bumi bumi commented Aug 4, 2024

this adds a default linux installation script to download and run Alby Hub on a plain Linux machine.

this adds a default linux installation script to download and run Alby
Hub on a plain Linux machine.
to setup Alby Hub with a Caddy reverse proxy for TLS
@rolznz
Copy link
Contributor

rolznz commented Aug 5, 2024

Can / should we move the RPI ones into their own folder?

@bumi
Copy link
Contributor Author

bumi commented Aug 5, 2024

I think so, yes, but this would change the URLs that's why I left it.

@rolznz
Copy link
Contributor

rolznz commented Aug 6, 2024

@bumi I guess it is better to fix it now than later - anyway the way the update works is it will get the correct script file from getalby.com, right? so the impact should be minimal?

@bumi
Copy link
Contributor Author

bumi commented Aug 6, 2024

@rolznz done.

@JPLACLAU can you help checking the URLs used.
we should use this https://getalby.com/install/hub/pi-zero-install.sh install URL

@bumi bumi requested a review from rolznz August 6, 2024 12:00
Run the installation script on your server:

$ wget https://raw.githubusercontent.com/getAlby/hub/master/scripts/linux-x86_64/install.sh
$ ./install.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do this, it won't run as the correct user, right? it's not the same as the ssh command below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we mix two different users, if the user runs a different command next time they use a different user. In my opinion this is confusing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why they run next time a differnt user?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 commands they can run - if the next time they use a different one based on whether they are ssh'd in or not, it uses a different user. I did this by accident

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which 2 commands are you talking about and why would the user be different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the current version: https://github.com/getAlby/hub/pull/415/files

}).WithError(err).Error("Failed to publish event")
requestEvent.State = db.REQUEST_EVENT_STATE_HANDLER_ERROR
} else {
requestEvent.State = db.REQUEST_EVENT_STATE_HANDLER_EXECUTED
logger.Logger.WithFields(logrus.Fields{
"requestEventNostrId": event.ID,
"responseEventNostrId": resp.ID,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. no idea how this got in there. 😱
should be in another branch - but I still want this in.

@bumi
Copy link
Contributor Author

bumi commented Aug 6, 2024

merging it as I need it.

@bumi bumi merged commit 4c18fc5 into master Aug 6, 2024
8 checks passed
@bumi bumi deleted the linux-install-script branch August 6, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants