Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: display recently closed channels #590

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Sep 2, 2024

Partially addresses #114

  • pass a query param to include closed channels so it doesn't break other parts of the app which expect only open channels
  • Use pending_balances_from_channel_closures to get the local channel balance for the closed channel
    • research how to get the local balance in LND - maybe the event is sufficient
  • Consume Close Channel Events to get the reason for the closure and so we only show "closing" state for force closures

There is currently a big downside: we do not know how much local balance the channel has at time of closing.

And we do not check if the funding transaction funds have moved, so we also cannot show the balance of the closed channel as pending balance on the savings balance card.

For channels older than 2 weeks, these are currently not shown.

image

image

@rolznz
Copy link
Contributor Author

rolznz commented Sep 3, 2024

Closing to look at alternatives - if LDK can return closed channels then this is not needed, and if they can return the peer alias then we also don't need to keep extra data on our channels.

@rolznz rolznz closed this Sep 3, 2024
@rolznz rolznz reopened this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant