chore: make silhouttte svgs opaque #704
Conversation
| <svg xmlns="http://www.w3.org/2000/svg" width="667" height="800" fill="none"> | ||
| <path fill="gray" |
There was a problem hiding this comment.
I think we should also use fill=currentColor" so we can specify it. Gray seems to not be so clear in light vs dark mode.
There was a problem hiding this comment.
We should make it into an icon if we want thi currentColor to work, because we are currently passing this svg as an src to img tag , should I make this white instead of gray? It would look like this then:
fill = "white" |
fill = "gray" |
|
|
Current
There was a problem hiding this comment.
@im-adithya this won't work on dark mode, right?
Actually I was wrong, if gray is completely half way between black and white it should be ok. We might just need to make the opacity stronger in light mode vs dark mode, since it seems less visible there.
HTML / CSS defined gray at the midpoint of the 8-bit gray scale (128,128,128).
There was a problem hiding this comment.
Ah yes it wouldn't, but actually the current one as is looks good both on Light Mode and Dark Mode
Light Mode |
Dark Mode |
|
|
There was a problem hiding this comment.
@im-adithya the light and dark mode are back to front, but the one with the black background is very hard to see the silhoutte. Can we use a different opacity on that one? e.g. opacity-40 dark:opacity-20
There was a problem hiding this comment.
Done! Looks better now!
Light Mode |
Dark Mode |
|
|
Should be easier to adjust opacity now using css
Light Mode
Dark Mode