Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hide preimage in failed payment dialog #705

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: hide preimage in failed payment dialog #705

merged 2 commits into from
Sep 25, 2024

Conversation

im-adithya
Copy link
Member

Before

After
Screenshot 2024-09-25 at 10 22 53 AM Screenshot 2024-09-25 at 10 23 58 AM

@im-adithya
Copy link
Member Author

Should we also hide the fee?

@rolznz
Copy link
Contributor

rolznz commented Sep 25, 2024

Should we also hide the fee?

I think so, a fee cannot be collected if the payment fails so it will always be zero

rolznz
rolznz approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz rolznz merged commit fff8c2c into master Sep 25, 2024
9 checks passed
@rolznz rolznz deleted the task-failed branch September 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@im-adithya @rolznz