fix: prevent user starting wails app twice #709
Conversation
| @@ -20,6 +21,14 @@ var assets embed.FS | |||
| var appIcon []byte | |||
|
|
|||
| func main() { | |||
| // Get a port lock on a rare port to prevent the app running twice | |||
| listener, err := net.Listen("tcp", "0.0.0.0:21420") | |||
There was a problem hiding this comment.
crazy. does this work across OS?
and it just listens but does not do anything? can we maybe write a pid-file like file to th working dir?
There was a problem hiding this comment.
I think writing a file is not so good because there is no guarantee it will be cleaned up. Trying to reserve a port seems safer to me
There was a problem hiding this comment.
that's a point. though most processes do write pid files for that case. I just have never seen an app reserving a port for this.
was wondering what are potential side effects.
There was a problem hiding this comment.
i think this is a very creative approach, also wondered about side effects, but the fact that you don't run into lockfile problems is quite great.
Fixes #467
The simplest change to prevent Alby Hub running twice in Wails mode which could potentially cause corruption of the LDK directory. This is equivalent to how the http mode prevents it, but even better because the port is allocated even before the service starts.