Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom TLVs storage #31

Merged
merged 6 commits into from
Jun 14, 2024
Merged

feat: custom TLVs storage #31

merged 6 commits into from
Jun 14, 2024

Conversation

rolznz
Copy link

@rolznz rolznz commented Jun 13, 2024

No description provided.

@rdmitr
Copy link
Collaborator

rdmitr commented Jun 13, 2024

I have updated the PR. However, when processing PaymentClaimable, I opted not to error out if custom TLVs are not available; instead, I store empty TLVs list. I felt that since TLVs are inherently optional, we can accept empty ones. Please let me know if I got it wrong :)

@rolznz rolznz changed the title feat: custom TLVs storage WIP feat: custom TLVs storage Jun 14, 2024
@rolznz rolznz marked this pull request as ready for review June 14, 2024 05:27
@rolznz
Copy link
Author

rolznz commented Jun 14, 2024

@rdmitr nice! I made a few minor changes, but everything works great 🚀

@rolznz rolznz merged commit 63f0d41 into main Jun 14, 2024
9 of 14 checks passed
@bumi
Copy link

bumi commented Jun 14, 2024

I can't really read it, but you two are awesome. @rdmitr @rolznz thanks!

@bumi bumi deleted the feat/custom-tlvs-storage branch June 14, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants