chore: remove topup tip (#2950)

* chore: remove topup tip * fix: test --------- Co-authored-by: René Aaron <[email protected]>
getAlby · Dec 20, 2023 · a5181a7 · a5181a7
1 parent 21d5d54
commit a5181a7
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 98 deletions.
diff --git a/src/app/components/Tips/index.test.tsx b/src/app/components/Tips/index.test.tsx
@@ -21,7 +21,6 @@ describe("Tips", () => {
       </I18nextProvider>
     );
 
-    expect(await screen.findByText("Buy Bitcoin")).toBeInTheDocument();
     expect(await screen.findByText("Alby Demo")).toBeInTheDocument();
     expect(await screen.findByText("Nostr")).toBeInTheDocument();
   });

diff --git a/src/app/components/Tips/index.tsx b/src/app/components/Tips/index.tsx
@@ -5,7 +5,6 @@ import { Link } from "react-router-dom";
 import TipCard from "~/app/components/TipCard";
 import { useAccount } from "~/app/context/AccountContext";
 import { useTips } from "~/app/hooks/useTips";
-import BuyBitcoinTipCardIcon from "~/app/icons/BuyBitcoinTipCardIcon";
 import DemoTipCardIcon from "~/app/icons/DemoTipCardIcon";
 import MnemonicTipCardIcon from "~/app/icons/MnemonicTipCardIcon";
 import { classNames } from "~/app/utils";
@@ -21,14 +20,6 @@ export default function Tips() {
   const tipCardConfigs = useMemo(
     () =>
       ({
-        [TIPS.TOP_UP_WALLET]: {
-          background:
-            "bg-white dark:bg-surface-02dp hover:bg-orange-50 dark:hover:bg-orange-900",
-          border: "border-orange-500",
-          arrow: "text-orange-500",
-          backgroundIcon: <BuyBitcoinTipCardIcon />,
-          link: "https://getalby.com/topup",
-        },
         [TIPS.DEMO]: {
           background:
             "bg-white dark:bg-surface-02dp hover:bg-yellow-50 dark:hover:bg-yellow-900",

diff --git a/src/app/hooks/useTips.test.ts b/src/app/hooks/useTips.test.ts
diff --git a/src/app/hooks/useTips.ts b/src/app/hooks/useTips.ts
@@ -1,38 +1,19 @@
-import { useAccount } from "~/app/context/AccountContext";
 import { useSettings } from "~/app/context/SettingsContext";
-import { isAlbyLNDHubAccount, isAlbyOAuthAccount } from "~/app/utils";
 import { TIPS } from "~/common/constants";
 
-const DEFAULT_TIPS = [TIPS.TOP_UP_WALLET, TIPS.MNEMONIC];
+const DEFAULT_TIPS = [TIPS.MNEMONIC];
 
-export const filterTips = (
-  closedTips: TIPS[],
-  isAlbyOAuthAccount: boolean,
-  isAlbyLNDHubAccount: boolean
-) => {
+export const filterTips = (closedTips: TIPS[]) => {
   return DEFAULT_TIPS.filter((tip: TIPS) => {
     if (closedTips.includes(tip)) return false;
 
-    if (
-      tip === TIPS.TOP_UP_WALLET &&
-      !isAlbyOAuthAccount &&
-      !isAlbyLNDHubAccount
-    )
-      return false;
-
     return true;
   });
 };
 
 export const useTips = () => {
   const { settings, updateSetting } = useSettings();
-  const { account } = useAccount();
-
-  const tips = filterTips(
-    settings.closedTips,
-    isAlbyOAuthAccount(account?.connectorType),
-    isAlbyLNDHubAccount(account?.alias, account?.connectorType)
-  );
+  const tips = filterTips(settings.closedTips);
 
   const closeTip = (tip: TIPS) => {
     updateSetting({

diff --git a/src/common/constants.ts b/src/common/constants.ts
@@ -164,7 +164,6 @@ export enum CURRENCIES {
 }
 
 export enum TIPS {
-  TOP_UP_WALLET = "top_up_wallet",
   DEMO = "demo",
   MNEMONIC = "mnemonic",
 }