Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use relative path for the extension path for testing #2735

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rithvik-padma
Copy link
Contributor

Describe the changes you have made in this PR

The extension path used for testing is relative to the root project directory and not relative path. Windows is unable to detect it, to tackle this problem I have changed to relative path for the development which works on every system.

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Windows unable to detect the extension path from the dist folder so unable to add the extension path to the place where the chrome executable is present.

image

How has this been tested?

Ran all the tests and now everything is automated and works fine.

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable

@Rithvik-padma
Copy link
Contributor Author

@im-adithya Can u review this PR.
Thank you

@bumi bumi requested a review from im-adithya September 7, 2023 12:43
@bumi
Copy link
Collaborator

bumi commented Sep 18, 2023

@im-adithya You had looked into this? what is the status?

@im-adithya
Copy link
Member

Yeah, this works but just want others to test in different OSes just to be sure

@rolznz
Copy link
Contributor

rolznz commented Sep 19, 2023

@im-adithya I do not think this is needed. Tests are run through a yarn command and the dist folder is directly in the root of the project. Why do we need to use "../../../" which in my opinion indicates there is something wrong with the project on @Rithvik-padma 's machine

@Rithvik-padma
Copy link
Contributor Author

@im-adithya I do not think this is needed. Tests are run through a yarn command and the dist folder is directly in the root of the project. Why do we need to use "../../../" which in my opinion indicates there is something wrong with the project on @Rithvik-padma 's machine

This may be the case but I see that even other windows users are also facing similar kind of issue in loading the extension by puppeteer using the absolute path from the project root.
Can you please look into this issue on puppeteer repo.
It is old but I think it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants