Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Updated : Example for adding a new string #2936

Conversation

AdarshRawat1
Copy link
Contributor

Describe the changes you have made in this PR

This PR is dependent on PR #2896.
The purpose of this PR is to update the example in the README file that contains an outdated string.

Type of change

  • docs: Documentation update

Screenshots of the changes [optional]

The PR #2896 changes "add_account" to "connect_wallet"
image
So I have updated the example in README.md for "adding a new string".

Checklist

  • Update Docs & Guides

Updated instruction example for adding a new string.

Depends on - getAlby#2896
@rolznz
Copy link
Contributor

rolznz commented Dec 19, 2023

@AdarshRawat1 I don't think this is really needed - it's just an example of the syntax of adding a new translation key and value

@AdarshRawat1
Copy link
Contributor Author

@rolznz I just thought that the updates should be reflected in examples as well.
( I needed feedback on it ) Thank you for your feedback.

@reneaaron reneaaron marked this pull request as draft January 24, 2024 10:34
@reneaaron reneaaron closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants