fix: accomodate invoicesFor change in test

getAlby · Dec 11, 2023 · 50cbdc1 · 50cbdc1
1 parent 838b226
commit 50cbdc1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 19 deletions.
diff --git a/integration_tests/hodl_invoice_test.go b/integration_tests/hodl_invoice_test.go
@@ -156,10 +156,8 @@ func (suite *HodlInvoiceSuite) TestHodlInvoice() {
 	if err != nil {
 		fmt.Printf("Error when getting invoices %v\n", err.Error())
 	}
-	assert.Equal(suite.T(), 1, len(invoices))
-	assert.Equal(suite.T(), common.InvoiceStateError, invoices[0].State)
-	errorString := "FAILURE_REASON_INCORRECT_PAYMENT_DETAILS"
-	assert.Equal(suite.T(), errorString, invoices[0].ErrorMessage)
+	// make sure erroneous invoices are not listed
+	assert.Equal(suite.T(), 0, len(invoices))
 
 	transactionEntries, err := suite.service.TransactionEntriesFor(context.Background(), userId)
 	if err != nil {

diff --git a/integration_tests/internal_payment_test.go b/integration_tests/internal_payment_test.go
@@ -399,10 +399,9 @@ func (suite *PaymentTestSuite) TestInternalPaymentFail() {
 		fmt.Printf("Error when getting invoices %v\n", err.Error())
 	}
 
-	// check if first one is settled, but second one error (they are ordered desc by id)
-	assert.Equal(suite.T(), 2, len(invoices))
-	assert.Equal(suite.T(), common.InvoiceStateError, invoices[0].State)
-	assert.Equal(suite.T(), common.InvoiceStateSettled, invoices[1].State)
+	// check if first one is settled, second one is erroneous and hence isn't listed
+	assert.Equal(suite.T(), 1, len(invoices))
+	assert.Equal(suite.T(), common.InvoiceStateSettled, invoices[0].State)
 	transactionEntries, err := suite.service.TransactionEntriesFor(context.Background(), userId)
 	if err != nil {
 		fmt.Printf("Error when getting transaction entries %v\n", err.Error())

diff --git a/integration_tests/keysend_failure_test.go b/integration_tests/keysend_failure_test.go
@@ -106,11 +106,8 @@ func (suite *KeySendFailureTestSuite) TestKeysendPayment() {
 	if err != nil {
 		fmt.Printf("Error when getting invoices %v\n", err.Error())
 	}
-	assert.Equal(suite.T(), 1, len(invoices))
-	assert.Equal(suite.T(), common.InvoiceStateError, invoices[0].State)
-	assert.Equal(suite.T(), SendPaymentMockError, invoices[0].ErrorMessage)
-	assert.NotEmpty(suite.T(), invoices[0].RHash)
-	assert.NotEmpty(suite.T(), invoices[0].Preimage)
+	// make sure the erroneous invoice isn't listed
+	assert.Equal(suite.T(), 0, len(invoices))
 }
 
 func TestKeySendFailureTestSuite(t *testing.T) {

diff --git a/integration_tests/payment_failure_async_test.go b/integration_tests/payment_failure_async_test.go
@@ -123,9 +123,8 @@ func (suite *PaymentTestAsyncErrorsSuite) TestExternalAsyncFailingInvoice() {
 	if err != nil {
 		fmt.Printf("Error when getting invoices %v\n", err.Error())
 	}
-	assert.Equal(suite.T(), 1, len(invoices))
-	assert.Equal(suite.T(), common.InvoiceStateError, invoices[0].State)
-	assert.Equal(suite.T(), SendPaymentMockError, invoices[0].ErrorMessage)
+	// make sure the erroneous invoice isn't listed
+	assert.Equal(suite.T(), 0, len(invoices))
 
 	transactionEntries, err := suite.service.TransactionEntriesFor(context.Background(), userId)
 	if err != nil {

diff --git a/integration_tests/payment_failure_test.go b/integration_tests/payment_failure_test.go
@@ -134,9 +134,8 @@ func (suite *PaymentTestErrorsSuite) TestExternalFailingInvoice() {
 	if err != nil {
 		fmt.Printf("Error when getting invoices %v\n", err.Error())
 	}
-	assert.Equal(suite.T(), 1, len(invoices))
-	assert.Equal(suite.T(), common.InvoiceStateError, invoices[0].State)
-	assert.Equal(suite.T(), SendPaymentMockError, invoices[0].ErrorMessage)
+	// make sure the erroneous invoice isn't listed
+	assert.Equal(suite.T(), 0, len(invoices))
 
 	transactionEntries, err := suite.service.TransactionEntriesFor(context.Background(), userId)
 	if err != nil {