Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Feat: version display #475

Merged
merged 9 commits into from
Jun 22, 2024
Merged

Feat: version display #475

merged 9 commits into from
Jun 22, 2024

Conversation

rolznz
Copy link
Collaborator

@rolznz rolznz commented Jun 21, 2024 •
edited
Loading

version is passed to the go app at build time

  • Linux amd64 Dockerfile action
  • Wails github action
  • RPI github action

bumi
bumi reviewed Jun 21, 2024
View reviewed changes
api/api.go Outdated Show resolved Hide resolved
version/version.go Show resolved Hide resolved
@rolznz rolznz requested a review from rdmitr June 21, 2024 16:02
rdmitr
rdmitr approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@rdmitr rdmitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rolznz rolznz marked this pull request as ready for review June 22, 2024 05:10
@rolznz rolznz merged commit bd29036 into master Jun 22, 2024
5 of 6 checks passed
@rolznz rolznz deleted the feat/version-display branch June 22, 2024 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bumi bumi bumi left review comments

@rdmitr rdmitr rdmitr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolznz @bumi @rdmitr