feat: update start api to be async #558
Conversation
|
Not sure if I should do this for wails, I think we should, but there isn't no option to check if the unlock password im wails, why is that? cc @rolznz |
@im-adithya we don't have an unlock screen on Wails because it can't be accessed from the outside. So I don't think it's necessary to make any changes there. |
|
Makes sense, that's what i thought, leaving this for Wails 👍 |
im-adithya
force-pushed
the
task-async-start
branch
from
db37db4 to
e6c8de8
Compare
| @@ -30,6 +30,15 @@ export function SetupFinish() { | |||
| }, | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
| const timer = setTimeout(() => { | |||
| if (!info?.running) { | |||
There was a problem hiding this comment.
This is not right, info will never change inside an effect. Each time it changes, the effect will run again.
There was a problem hiding this comment.
you don't even need to rely on info here, when the navigation occurs, the timeout will be cleaned up
There was a problem hiding this comment.
I'm using info somewhere so that I don't get the unused error. Because we have to keep polling the info. I just added the eslint unused vars comment now, can you check now? I think it should be good to merge now, tested thoroughly.
There was a problem hiding this comment.
@im-adithya I pushed a fix for it, please have a look
Fixes getAlby/hub#27
(The video is outdated, removed messages from Setup Screen, we only show them in the Start screen now)
What Changed
Screen.Recording.2024-07-02.at.1.36.04.PM.mov