Feat: lookup invoice (Alby + LND) #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Aug 28, 2023
rolznz
changed the title
kiwiidb
suggested changes
Aug 29, 2023
|
|
||
| paymentHash := lookupInvoiceParams.PaymentHash | ||
|
|
||
| if (paymentHash == "") { |
There was a problem hiding this comment.
If I was the author of the NIP PR I would drop the payment_request parameter and mandate payment_hash. But not really related to this PR so OK.
There was a problem hiding this comment.
Should we give feedback? this is the time to do it
There was a problem hiding this comment.
I think the user always has access to the payment hash, as long as the invoice was generated through NWC.
kiwiidb
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alby currently returns 404 for unsettled invoices