Replace .form UI files with Kotlin UI DSL v2

[jansorg]

Closes #548

Replaces the .form files with UI DSL v2. Support for .form files is deprecated and mostly unmaintained by JetBrains now.

Previously, code instrumentation via the IntelliJ Gradle plugin was used to create .class files from the JetBrains .form files. Instrumentation is not needed anymore and is disabled by this PR.

UI DSL v2 needs Kotlin. This PR enables Kotlin to allow writing the UI DSL code, but everything else is going to remain Java source code.

Unfortunately, the UI DSL isn't backwards compatible in a few places. We're dropping support for 2021.3 to fix this.

Settings:

Start AppMap recording:

Stop AppMap recording:

[ahtrotta]

When I run the plugin locally, I get this warning related to this change:

> Task :plugin-core:compileKotlin
w: Lombok Kotlin compiler plugin is an experimental feature. See: https://kotlinlang.org/docs/components-stability.html.
w: file:///home/ahtrotta/projects/appmap/appmap-intellij-plugin/plugin-core/src/main/kotlin/appland/remote/StartRemoteRecordingForm.kt:22:22 'horizontalAlign(HorizontalAlign): Cell<T>' is deprecated. Use align(AlignX.LEFT/CENTER/RIGHT/FILL) method instead
w: file:///home/ahtrotta/projects/appmap/appmap-intellij-plugin/plugin-core/src/main/kotlin/appland/remote/StopRemoteRecordingForm.kt:18:60 'horizontalAlign(HorizontalAlign): Cell<T>' is deprecated. Use align(AlignX.LEFT/CENTER/RIGHT/FILL) method instead
w: file:///home/ahtrotta/projects/appmap/appmap-intellij-plugin/plugin-core/src/main/kotlin/appland/remote/StopRemoteRecordingForm.kt:25:43 'horizontalAlign(HorizontalAlign): Cell<T>' is deprecated. Use align(AlignX.LEFT/CENTER/RIGHT/FILL) method instead

Could you address this? Thanks!

[jansorg]

@ahtrotta Is it possible that you were compiling for a later SDK?
I'm not seeing these warnings with the default platform version, but I know that later versions added deprecations like this.

[ahtrotta]

@ahtrotta Is it possible that you were compiling for a later SDK? I'm not seeing these warnings with the default platform version, but I know that later versions added deprecations like this.

Yeah I was using 2023.3.2

[github-actions]

AppMap runtime code review

Summary	Status
Failed tests	✅ All tests passed
API changes	0️⃣ No API changes
Security flaws	✅ None detected
Performance problems	✅ None detected
Code anti-patterns	✅ None detected
New AppMaps	⭐ 1 new junit test
Removed AppMaps	✖️ 1 removed junit test

⭐ New AppMaps

[junit] Findings manager modification dates from plugin-core/src/test/java/appland/problemsView/FindingsManagerTest.java:69

✖️ Removed AppMaps

[junit] App map search scopes app map config scope

[ahtrotta]

@jansorg what is the status of this PR?

[jansorg]

There's a flaky test, but only on CI. I'll fix it soon.
It's not a user-visible change, so it's not important for UX/UI testing.

[ahtrotta]

There's a flaky test, but only on CI. I'll fix it soon. It's not a user-visible change, so it's not important for UX/UI testing.

Thanks for the update! I was just wondering because the issue is in the In Review column on the board but it's marked as a draft PR. I'll move the issue to In Progress.

[jansorg]

Oh, sorry! I thought it was ready, but missed the test.

[jansorg]

When I run the plugin locally, I get this warning related to this change:

> Task :plugin-core:compileKotlin
w: Lombok Kotlin compiler plugin is an experimental feature. See: https://kotlinlang.org/docs/components-stability.html.
w: file:///home/ahtrotta/projects/appmap/appmap-intellij-plugin/plugin-core/src/main/kotlin/appland/remote/StartRemoteRecordingForm.kt:22:22 'horizontalAlign(HorizontalAlign): Cell<T>' is deprecated. Use align(AlignX.LEFT/CENTER/RIGHT/FILL) method instead
w: file:///home/ahtrotta/projects/appmap/appmap-intellij-plugin/plugin-core/src/main/kotlin/appland/remote/StopRemoteRecordingForm.kt:18:60 'horizontalAlign(HorizontalAlign): Cell<T>' is deprecated. Use align(AlignX.LEFT/CENTER/RIGHT/FILL) method instead
w: file:///home/ahtrotta/projects/appmap/appmap-intellij-plugin/plugin-core/src/main/kotlin/appland/remote/StopRemoteRecordingForm.kt:25:43 'horizontalAlign(HorizontalAlign): Cell<T>' is deprecated. Use align(AlignX.LEFT/CENTER/RIGHT/FILL) method instead

Could you address this? Thanks!

@ahtrotta I've fixed the test, this PR is ready for review now.
Because the above API was only added in a later version of the SDK, we're unable to fix it.

[ahtrotta]

@ahtrotta I've fixed the test, this PR is ready for review now. Because the above API was only added in a later version of the SDK, we're unable to fix it.

Okay, great I'll take a look!

[appland-release]

🎉 This PR is included in version 0.56.0 🎉

The release is available on:

• v0.56.0
• GitHub release

Your semantic-release bot 📦🚀