Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fp fix of adv sql injection #2

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

itsdivyanshjain
Copy link

@itsdivyanshjain itsdivyanshjain commented May 6, 2024

Overview

Briefly describe the purpose, goals, and changes or improvements made in this pull request.

  1. Rejected Intial request if status code range in 3**-5**
  2. Rejected static pages (css, js , image,font)
  3. Specifically rejected 4** response when utilised injected payload.

Note: This PR also contains earlier time based FP fix, which we can neglect for now

Related Issues

Specify any related issues or pull requests by linking to them.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

For more details, please refer to the developer rules and guidelines.

Signed-off-by: divyansh jain <[email protected]>
@divyanshjainATastra divyanshjainATastra self-assigned this May 6, 2024
@divyanshjainATastra divyanshjainATastra added the don't merge Wait to merge this PR label May 6, 2024
karthik-uj
karthik-uj previously approved these changes May 8, 2024
@karthik-uj
Copy link

Looks good

@twelcon
Copy link

twelcon commented Oct 25, 2024

Converted this template to draft so that it won't appear in our product-sprint channel updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Wait to merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants