Upgrade kmp and java apps to use 5.0.0-preview.3 #186

phatblat · 2025-10-06T20:46:15Z

Preview 3 is not yet public. It is accessible to authorized users via the maven central staging APIs.

Renamed java-spring/ to java-server/
Added java-server/java-spring-maven/ subproject for testing Maven compatibility

Copilot

Pull Request Overview

Upgrades Kotlin Multiplatform and Java applications to use Ditto SDK version 5.0.0-preview.3, updating the API implementation to match the new SDK interface.

Updated Ditto SDK version from 5.0.0-preview.1 to 5.0.0-preview.3
Migrated from DittoIdentity-based authentication to new authentication provider pattern
Changed API method calls to use new naming conventions (e.g., registerObserver to observe, getString to asString)

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
kotlin-multiplatform/composeApp/build.gradle.kts	Updated Ditto dependency versions to 5.0.0-preview.3
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt	Refactored Ditto initialization to use new authentication pattern and updated API calls
kotlin-multiplatform/composeApp/src//kotlin/com/ditto/quickstart/ditto/DittoManager..kt	Updated platform-specific Ditto creation to use DittoFactory
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/data/DittoCredentials.kt	Added new data class for Ditto credentials
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/di/DittoModule.kt	Updated dependency injection to include credentials
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/data/repository/DittoTaskRepository.kt	Updated API method call from `registerObserver` to `observe`
kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ui/TaskAddEditScreen.kt	Minor UI layout adjustment
kotlin-multiplatform/README.md	Updated API reference link to preview.3 version
java-spring/src/main/java/com/ditto/example/spring/quickstart/service/DittoService.java	Migrated to new authentication pattern and updated transport configuration
java-spring/src/main/java/com/ditto/example/spring/quickstart/service/DittoTaskService.java	Updated API method calls to use new naming conventions
java-spring/build.gradle.kts	Updated Ditto dependency versions to 5.0.0-preview.3
java-spring/java-spring-maven/pom.xml	Added Maven configuration with preview.3 dependencies

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/di/DittoModule.kt

resolves issue on iOS where a new task couldn’t be added because the button is hidden behind the keyboard

russhwolf

What's the expected status of tests? The browserstack CI failure also happens for me locally, and I have similar failures in both the Android and iOS integration tests which are not being run in CI.

Otherwise, mostly nits here.

russhwolf · 2025-10-20T14:03:30Z

java-server/src/main/java/com/ditto/example/spring/quickstart/service/DittoTaskService.java

    @Nonnull
    public Flux<List<Task>> observeAll() {
-        final String selectQuery = "SELECT * FROM %s WHERE NOT deleted ORDER BY title ASC".formatted(TASKS_COLLECTION_NAME);
+        final String selectQuery = "SELECT * FROM %s WHERE NOT deleted".formatted(TASKS_COLLECTION_NAME);


Any particular reason to drop the ORDER BY here? The equivalent in the KMP quickstart retains it.

russhwolf · 2025-10-20T14:04:42Z

kotlin-multiplatform/README.md


 - [Kotlin Multiplatform Roadmap and Support Policy](https://docs.ditto.live/sdk/latest/install-guides/kotlin/multiplatform-roadmap)
- [API Reference](https://software.ditto.live/java/ditto-java/5.0.0-preview.1/api-reference/)
+- [API Reference](https://software.ditto.live/java/ditto-java/5.0.0-preview.3/api-reference/)


The new API reference doesn't appear to be deployed yet

russhwolf · 2025-10-20T14:15:32Z

...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt

-    private val scope = CoroutineScope(SupervisorJob())
+    val secrets: DittoSecretsConfiguration
+
+    constructor(secrets: DittoSecretsConfiguration) {
+        this.secrets = secrets
+        this.scope = CoroutineScope(SupervisorJob())
+    }
+
+    private val scope: CoroutineScope


Nit: this change isn't really necessary, but it all works fine.

I don't see any reason the scope needs to move inside a constructor. For the DittoSecretsConfiguration, you could just as easily statically reference it in-line, though storing it as a property protects against some potential refactors.

russhwolf · 2025-10-20T14:16:50Z

...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt

-                    // Cloud sync is intentionally disabled to avoid authentication issues in test environments.
-                    // When enabled, Ditto Cloud Sync requires additional auth setup that causes certificate 
-                    // validation failures in BrowserStack. Disabling ensures sync occurs via WebSocket URLs only.
-                    enableDittoCloudSync = false,


This configuration is no longer happening explicitly. Is there any reason we might still want to hold onto some version of the comment? (I lean toward no, but want to ask the question anyway)

russhwolf · 2025-10-20T14:17:50Z

...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt

+                ).apply {
+                    auth?.setExpirationHandler { ditto, secondsRemaining ->
+                        // Authenticate when a token is expiring
+                        val clientInfo = ditto.auth?.login(


clientInfo is unused here

russhwolf · 2025-10-20T14:20:05Z

...in-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/ditto/DittoManager.kt

+                            provider = DittoAuthenticationProvider.development(),
+                        )
+                    }
+                }.apply {


Nit: All this stuff could live in a single apply block instead of two

russhwolf

Moving to approve after in-person convo that we haven't been maintaining those tests. We should probably update them at some point but I don't want to gatekeep this PR on that.

phatblat self-assigned this Oct 6, 2025

phatblat force-pushed the ben/kotlin-java-5.0-preview.3 branch 2 times, most recently from e0d95f1 to f133c2f Compare October 10, 2025 16:44

phatblat marked this pull request as ready for review October 10, 2025 16:44

phatblat requested a review from busec0 as a code owner October 10, 2025 16:44

phatblat requested review from Copilot and russhwolf October 10, 2025 16:44

Copilot AI reviewed Oct 10, 2025

View reviewed changes

kotlin-multiplatform/composeApp/src/commonMain/kotlin/com/ditto/quickstart/di/DittoModule.kt Outdated Show resolved Hide resolved

phatblat force-pushed the ben/kotlin-java-5.0-preview.3 branch from f133c2f to f7377a2 Compare October 14, 2025 23:53

phatblat requested a review from a team as a code owner October 14, 2025 23:55

phatblat force-pushed the ben/kotlin-java-5.0-preview.3 branch 3 times, most recently from 4735823 to 988c595 Compare October 15, 2025 15:30

phatblat added 9 commits October 16, 2025 12:02

build(deps): use ditto 5.0.0-preview.3 in kmp

2624bce

apply patch

3ab8b78

build(deps): upgrade to ditto 5.0.0-preview.3 in java-spring

41ec1fd

refactor: update java apis to use as*() deserialization methods

cd686db

refactor: use DittoSecretsConfiguration

5e22193

refactor: update APIs for v5 preview 3

ddfe951

fix: add SUBSCRIPTION_QUERY_SELECT_TASKS with no ORDER BY

de5c361

refactor: explicitly enable P2P transports

ebed6a9

refactor: vertically align Add Task screen

64c1a73

resolves issue on iOS where a new task couldn’t be added because the button is hidden behind the keyboard

phatblat force-pushed the ben/kotlin-java-5.0-preview.3 branch from 988c595 to 1990e36 Compare October 17, 2025 22:16

phatblat added 3 commits October 17, 2025 16:40

refactor: move java-spring repo configuration to settings.gradle.kts

cacd2cf

refactor: rename java-spring -> java-server

48754cc

refactor: use DittoSecretsConfiguration to configure Ditto

b9055f9

phatblat force-pushed the ben/kotlin-java-5.0-preview.3 branch from 1990e36 to b9055f9 Compare October 17, 2025 22:49

russhwolf reviewed Oct 20, 2025

View reviewed changes

russhwolf approved these changes Oct 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade kmp and java apps to use 5.0.0-preview.3 #186

Upgrade kmp and java apps to use 5.0.0-preview.3 #186

Uh oh!

phatblat commented Oct 6, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

russhwolf left a comment

Uh oh!

russhwolf Oct 20, 2025

Uh oh!

russhwolf Oct 20, 2025

Uh oh!

russhwolf Oct 20, 2025

Uh oh!

russhwolf Oct 20, 2025

Uh oh!

russhwolf Oct 20, 2025

Uh oh!

russhwolf Oct 20, 2025

Uh oh!

russhwolf left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Upgrade kmp and java apps to use 5.0.0-preview.3 #186

Are you sure you want to change the base?

Upgrade kmp and java apps to use 5.0.0-preview.3 #186

Uh oh!

Conversation

phatblat commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

russhwolf left a comment

Choose a reason for hiding this comment

Uh oh!

russhwolf Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

russhwolf Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

russhwolf Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

russhwolf Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

russhwolf Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

russhwolf Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

russhwolf left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

phatblat commented Oct 6, 2025 •

edited

Loading