Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build #538

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

AstralStorm
Copy link

Fixes #537. Stubby will need an update once its service fix PR is merged.

Fixes all found instances of missing APIs and headers on Windows.
@saradickinson
Copy link
Contributor

@wtoorop I've merged the related Stubby PR and updated the submodule. With the fixes in this PR everything builds on Windows again, so this can be merged if you are happy with it.

@wtoorop
Copy link
Contributor

wtoorop commented Jan 10, 2023

@wtoorop I've merged the related Stubby PR and updated the submodule. With the fixes in this PR everything builds on Windows again, so this can be merged if you are happy with it.

Yes, will do, I just have to make sure the changes to gldns are also in upstream Unbound's sldns so they won't be reversed in the future again when syncing up with Unbound.

@BillyONeal
Copy link

We see this build failure in the update submitted by @jiayuehua . See microsoft/vcpkg#34188

(As an aside it would be nice to have a variable we can turn off to disable generating docs instead of patching but that's unrelated)

@BillyONeal
Copy link

I note that their patch also guards for HAVE_TIME_H

@MonicaLiu0311
Copy link

Any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getdns no longer builds on Windows
5 participants