fix: regex correctly matches url() referenced assets #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, adjusted how greedy the regex is and added links out to Regex101.com for easy future reference This fix addresses the issue reported here: getgrav#7
|
@bsheen I also ran into this issue. When looking at your PR I noticed the regex in your comment is slightly different than the actual code. In the comment you take into account both types of brackets |
|
@DanYoSon it's most likely an oversight on my part. I think that double quotes should be included as per the comments and demonstrated here: |
|
@bsheen I suspected that that was what happened. I just wanted to make sure I wasn't missing something and that there was something to learn :) |
|
Sorry it took so long.. fixed with double quote too. |
|
Thanks @rhukster! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, adjusted how greedy the regex is and added
links out to Regex101.com for easy future reference
This fix addresses the issue reported here:
#7