Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to add trace context to logs #547

Merged
merged 4 commits into from
Oct 21, 2024
Merged

fix: attempt to add trace context to logs #547

merged 4 commits into from
Oct 21, 2024

Conversation

morgante
Copy link
Contributor

@morgante morgante commented Oct 21, 2024

More context:

The problem seems to be that opentelemetry doesn't fully track the context well across all async boundaries when using instrument from tracing.

Therefore, I instead just rely directly on retrieving the current trace from tracing.

Greptile Summary

This is an auto-generated summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

@morgante morgante marked this pull request as ready for review October 21, 2024 23:49
@morgante morgante requested a review from a team as a code owner October 21, 2024 23:49
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@morgante morgante merged commit aa3de5d into main Oct 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant