This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
V3.0 #131
Open
V3.0 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was adding integrity and crossorigin attributes to the previous version of LABjs. I know that it is no longer in active development so I thought I would propose the following addition to preloadResource and loadResource. There is a TODO for handling resource types in each routine. I added the following code to each routine where the TODO is:
if (registryEntry.opts) {
for ( var opt in registryEntry.opts ) {
if ( registryEntry.opts.hasOwnProperty(opt) && 'src' !== opt ) {
elem.setAttribute( opt, registryEntry.opts[opt] );
}
}
}
This preserves the feature of passing .script({src: "http://foobar.com/x.js", type: "text/whatever", charset: "EBCDIC"}) but makes it extensible.
index.js.txt