Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor grammar issues in chapter 3 of Async & Performance #1139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix minor grammar issues in chapter 3 of Async & Performance #1139

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2017

Hello,

Just offering suggestions for some minor grammar issues I came across while reading this chapter 3 of the Async & Performance book. Specifically,

  • Rewording: which more has our attention at present to which has more of our attention at present
  • Hyphen removal to be consistent with word usage: reason-able to reasonable

@getify
Copy link
Owner

getify commented Sep 10, 2017

The first change is slight but reasonable. However, the second change shifts meaning away from intent. "reasonable" commonly means "acceptable", but "reason-able" means "able to be reasoned about".

@ghost
Copy link
Author

ghost commented Sep 10, 2017

@getify, understood—I've redacted that second change.

@kricketune
Copy link

kricketune commented Sep 28, 2017

The word promisory should also be changed to promissory. He said promisory was an actual word, but I can't find it in any dictionary.

@getify
Copy link
Owner

getify commented Sep 28, 2017

There's already a logged issue to handle the difference in spelling of promisory vs promissory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants