Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to kfp 2 #170

Merged
merged 30 commits into from
Jul 29, 2024
Merged

Migrate to kfp 2 #170

merged 30 commits into from
Jul 29, 2024

Conversation

sfczekalski
Copy link
Contributor

Description

Migrated kfp from legacy 1.X.X to 2.8.0.

PR Checklist

@sfczekalski
Vertex AI pipelines client: list pipelines.
32df203
@sfczekalski
Very initial version of run once.
d7ba232
@sfczekalski
Pass parameters to pipeline job.
6550422
@sfczekalski
Add type annotation to task passed to _configure_resources.
c9b1dff
@sfczekalski
Remove image pull policy parameter as it's not supported.
a159230
@sfczekalski
Mlflow component.
76b6c6b
@sfczekalski
Add mlflow component and pass run id to downstream components.
89499ce
@sfczekalski
Rename ops to tasks.
1bf52fb
@sfczekalski
Wait for completion.
e5eb306
@sfczekalski
Remove io.py file as it's not used anyway.
300ee39
@sfczekalski
Pre-commit fixes.
7783275
@sfczekalski
Test if resources are correctly added to the pipeline spec.
100af95
@sfczekalski
Test that resources section is not added to spec if it wasn't specified.
4a63027
@sfczekalski
Test grouping nodes.
ce99cdb
@sfczekalski
Test adds mlflow task.
d049d3d
@sfczekalski
Test runner and runner config in args.
8aadde5
@sfczekalski
Finish other tests.
1ba7238
@sfczekalski
Add unittest.skip to test_should_remove_old_schedule for now.
7e704e8
@sfczekalski
List pipelines test.
2200a87
@sfczekalski
Test compile.
d084e76
@sfczekalski
Patch mlflow is enabled when setting mlflow tags.
a9401e2
@sfczekalski
Update test_run_once_with_wait test.
a67b2bf
@sfczekalski
Update changelog.
1c9baf9
@sfczekalski sfczekalski requested a review from Lasica July 23, 2024 14:47
@em-pe
Copy link
Member

em-pe commented Jul 23, 2024

Good work, just address the issues that sonarcloud caught https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&pullRequest=170&id=getindata_kedro-vertexai

Additionally maybe we should update the python version that runs e2e tests to python 3.10 in

kedro-vertexai/.github/workflows/test_and_publish.yml

Line 108 in 56fff64

python-version: ['3.8'] # todo update python
and

kedro-vertexai/.github/workflows/test_and_publish.yml

Line 194 in 56fff64

python-version: ['3.8']

adobrogows-ki
adobrogows-ki reviewed Jul 24, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
adobrogows-ki
adobrogows-ki reviewed Jul 24, 2024
View reviewed changes
Copy link

@adobrogows-ki adobrogows-ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 questions, I didn't catch anything that would need fixing. Good job :) I'm not familiar with kfp that much and would need to run it myself to check how it works now.

@em-pe em-pe self-requested a review July 24, 2024 09:47
@sfczekalski sfczekalski changed the title Migrate to kfp 2.8.0 Migrate to kfp 2 Jul 26, 2024
@em-pe em-pe self-requested a review July 29, 2024 10:00
@sfczekalski sfczekalski merged commit 0e934f9 into develop Jul 29, 2024
12 checks passed
@sfczekalski sfczekalski deleted the migrate_to_kfp2 branch July 29, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adobrogows-ki adobrogows-ki adobrogows-ki left review comments

@em-pe em-pe em-pe approved these changes

@Lasica Lasica Awaiting requested review from Lasica

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfczekalski @em-pe @adobrogows-ki